fix(tia): suppress PHPUnit XML coverage during recording - #1845
Merged
Conversation
calebdw
force-pushed
the
calebdw/push-pkmorwmqossv
branch
from
August 17, 2026 20:36
c9c8071 to
5b38596
Compare
Contributor
Author
|
@nunomaduro, recording tia in ci is broken for every project that has |
MrPunyapal
approved these changes
Aug 25, 2026
MrPunyapal
requested changes
Aug 25, 2026
MrPunyapal
left a comment
MrPunyapal
left a comment
Collaborator
There was a problem hiding this comment.
Two things before this can merge:
- Rector fails on the heredoc indentation in tests/Features/Tia/CoveragePiggyback.php
- The new test "xml-configured coverage does not prevent tia recording" fails in the integration suite, with exit code 1 instead of 0. Maybe it needs an env guard like the other TIA tests.
Once CI is green, we can merge.
When phpunit.xml has <coverage> and <source> sections, PHPUnit auto-initializes its code coverage driver which takes over xdebug's coverage APIs. TIA's recorder then gets empty data from xdebug_get_code_coverage(), resulting in zero recorded edges and no graph being saved. Inject --no-coverage into the arguments when TIA enters its own recording mode (not piggybacking on an explicit coverage report). This tells PHPUnit to ignore XML-configured coverage reports, leaving xdebug free for TIA's per-test recording. Having <coverage> and <source> in phpunit.xml is standard for any project that generates coverage reports. Without this fix, users must manually pass --no-coverage alongside --tia, which is an unnecessary footgun.
calebdw
force-pushed
the
calebdw/push-pkmorwmqossv
branch
from
August 25, 2026 19:41
e0f66c5 to
190ade6
Compare
Contributor
Author
|
@MrPunyapal, looks like it needs approval to run |
MrPunyapal
approved these changes
Aug 25, 2026
Collaborator
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
When phpunit.xml has
<coverage>and<source>sections, PHPUnit auto-initializes its code coverage driver which takes over xdebug's coverage APIs. TIA's recorder then gets empty data fromxdebug_get_code_coverage(), resulting in zero recorded edges and no graph being saved.